This repository was archived by the owner on Dec 28, 2024. It is now read-only.
bump minimum version of go used to build cli#103
Open
techknowlogick wants to merge 1 commit intosvix:mainfrom
Open
bump minimum version of go used to build cli#103techknowlogick wants to merge 1 commit intosvix:mainfrom
techknowlogick wants to merge 1 commit intosvix:mainfrom
Conversation
Member
|
Thanks, the team will take a look! |
Author
|
Hi @tasn, would you, or someone else at svix, be able to poke at this PR? |
Author
|
@svix-jplatte would you be able to take a look at this PR? |
Member
|
Yes, just did. Unfortunately I'm not at all familiar with Go, so it's hard for me to tell whether the (seemingly tool-generated) changes are okay. Would you mind providing the steps you went through to arrive at this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the CLI setting go.mod to go1.16 building the CLI fails due to modules requiring a newer version of go.
Errors received:
This PR is the result of bumping go.mod to go1.17, and running
go mod tidyNote: I am running into this error because I am attempting to package the CLI for NixOS, which has a specific way of building software to ensure reproducible builds.