Skip to content

python: Support field-less object types #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

python: Support field-less object types #1801

merged 1 commit into from
Mar 6, 2025

Conversation

svix-jplatte
Copy link
Member

We've got some field-less object types in the next version of our API spec.

@svix-jplatte svix-jplatte requested a review from a team as a code owner March 6, 2025 15:18
svix-mman
svix-mman approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@svix-mman svix-mman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like merging template changes without seeing how they affect the generated code :(

@svix-jplatte
Copy link
Member Author

Ack. I was planning to make a PR that disables most of the libs in codegen.toml and pulls in the latest spec soon. Then we could enable them again in subsequent PRs. How does that sound?

@svix-jplatte svix-jplatte merged commit 6948b1a into main Mar 6, 2025
10 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/py-empty-objs branch March 6, 2025 15:30
@svix-mman
Copy link
Contributor

that works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-mman svix-mman svix-mman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-jplatte @svix-mman