Skip to content

js: Add internal lib #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2025
Merged

js: Add internal lib #1823

merged 4 commits into from
Mar 19, 2025

Conversation

svix-mman
Copy link
Contributor

Add an internal lib for frontend.

The non-public models are not exported from 'src/models/index.ts'

@svix-mman svix-mman marked this pull request as ready for review March 17, 2025 14:55
@svix-mman svix-mman requested a review from a team as a code owner March 17, 2025 14:55
@svix-mman svix-mman requested a review from svix-lucho March 17, 2025 20:18
svix-lucho
svix-lucho approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@svix-lucho svix-lucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it, but just making sure since it's not in the description: api_internal is not exported from the root index, right?

@svix-mman
Copy link
Contributor Author

We discussed it, but just making sure since it's not in the description: api_internal is not exported from the root index, right?

Correct

@svix-mman svix-mman merged commit 8e1c2ef into main Mar 19, 2025
9 checks passed
@svix-mman svix-mman deleted the mendy/add-internal-js-lib branch March 19, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-lucho svix-lucho svix-lucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-mman @svix-lucho