svix-cli: Add interactive login #1846
Open
+127
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-james
previously approved these changes
Mar 28, 2025
svix-lucho
force-pushed
the
lucho/cli-login
branch
from
597c47c to
12930ec
Compare
svix-jplatte
reviewed
Apr 7, 2025
Comment on lines
+91
to
+94
| Err(e) => { | ||
| eprintln!("Failed to get session ID: {}", e); | ||
| return Err(anyhow::anyhow!("Failed to get session ID")); | ||
| } |
There was a problem hiding this comment.
Why print to stderr and return an error? Would the error not be printed otherwise?
Comment on lines
+116
to
+129
| let response = match client | ||
| .post(&poll_url) | ||
| .json(&serde_json::json!({ "sessionId": session_id })) | ||
| .send() | ||
| .await | ||
| { | ||
| Ok(resp) => resp, | ||
| Err(e) => { | ||
| return Err(anyhow::anyhow!( | ||
| "Failed to connect to authentication server: {}", | ||
| e | ||
| )); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let response = match client | |
| .post(&poll_url) | |
| .json(&serde_json::json!({ "sessionId": session_id })) | |
| .send() | |
| .await | |
| { | |
| Ok(resp) => resp, | |
| Err(e) => { | |
| return Err(anyhow::anyhow!( | |
| "Failed to connect to authentication server: {}", | |
| e | |
| )); | |
| } | |
| }; | |
| let response = client | |
| .post(&poll_url) | |
| .json(&serde_json::json!({ "sessionId": session_id })) | |
| .send() | |
| .awai | |
| .context("Failed to connect to authentication server")?; |
(need to use anyhow::Context)
Comment on lines
+132
to
+138
| match response.json::<AuthTokenOut>().await { | ||
| Ok(data) => { | ||
| println!("Authentication successful!\n"); | ||
| return Ok(data.token); | ||
| } | ||
| Err(_) => return Err(anyhow::anyhow!("Failed to parse auth token")), | ||
| } |
There was a problem hiding this comment.
Can also use .context() here (unless you think we should be hiding the deserialization error?)
| Err(_) => "Unknown error".to_string(), | ||
| }; | ||
|
|
||
| return Err(anyhow::anyhow!("Authentication failed: {}", error_message)); |
There was a problem hiding this comment.
Suggested change
| return Err(anyhow::anyhow!("Authentication failed: {}", error_message)); | |
| anyhow::bail!("Authentication failed: {error_message}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a selector when using
svix loginto log in using the dashboard.Demo:
Screen.Recording.2025-03-28.at.3.14.15.PM.mov