Skip to content

python: Fix minimum version for pydantic #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

svix-jplatte
Copy link
Member

@svix-jplatte svix-jplatte commented Apr 7, 2025

We are using ModelWrapValidatorHandler, which was introduced in 2.10

Also add maximum versions because it seems wrong that we don't have them.

We are using ModelWrapValidatorHandler, which was introduced in 2.10
@svix-jplatte svix-jplatte marked this pull request as ready for review April 7, 2025 13:24
@svix-jplatte svix-jplatte requested a review from a team as a code owner April 7, 2025 13:24
@svix-jplatte svix-jplatte merged commit 5ff2133 into main Apr 7, 2025
10 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/pydantic-min-version branch April 7, 2025 13:40
svix-jplatte added a commit that referenced this pull request Apr 7, 2025
…1870)

In #1869, I accidentally
changed the version requirement of setuptools to an ancient version.
Everything <70 is affected by a security issue, so bump the minimum
version to that and remove the upper bound again.
@mrbcmorris
Copy link

mrbcmorris commented Apr 14, 2025

@svix-jplatte Just ran into this in my application today so I've pinned svix to 16.2.0. Do we also need to declare pydantic > 2.10 in the setup.py file so pip is aware of this requirement?

I'm stuck on pydantic 2.9.2 until I update my application for compatibility with 2.10 so when I upgrade svix to 16.4.0 my application started failing.

@svix-jplatte
Copy link
Member Author

svix-jplatte commented Apr 14, 2025

You shouldn't have to declare pydantic > 2.10 yourself, no. I was not aware that 2.10 contains breaking changes, that's unfortunate. I hope it's not much of an issue for you to pin the svix dependency.

@mrbcmorris
Copy link

@svix-jplatte Sorry the suggestion was for svix to declare pydantic>2.10 in the setup.py file so pip could handle this requirement successfully. Regardless, pinning svix on my end is successful.

Appreciate the package, thank you for your time.

Cheers!

@svix-jplatte
Copy link
Member Author

Oh, that's a good point. We probably should, I'll send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants