-
Notifications
You must be signed in to change notification settings - Fork 186
Create new internal Go lib #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why add this to the SDK, rather than the terraform package? |
I kinda want to dog food the SDK, it feels bad to generate an extra lib. |
I was talking about only generating code there for the internal stuff. I don't see a big downside to this approach, one thing is that it doesn't allow us to later remove the hidden stuff from this repo, but that doesn't seem so important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the other approach might be too much extra work 🤷
I don't like the idea of exposing the internal workings ( |
Don't need to do that, could just duplicate. |
Create new Go internal API client
This client only has the limited set of operations needed for the terraform plugin
note: This is branched from #1884, I will rebase on main once #1884 is merged