Skip to content

Create new internal Go lib #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Create new internal Go lib #1885

merged 2 commits into from
Apr 15, 2025

Conversation

svix-mman
Copy link
Contributor

Create new Go internal API client

This client only has the limited set of operations needed for the terraform plugin

note: This is branched from #1884, I will rebase on main once #1884 is merged

@svix-mman svix-mman changed the base branch from main to mendy/prep-go-lib April 14, 2025 23:19
@svix-mman svix-mman marked this pull request as ready for review April 14, 2025 23:20
@svix-mman svix-mman requested a review from a team as a code owner April 14, 2025 23:20
@svix-jplatte
Copy link
Member

Why add this to the SDK, rather than the terraform package?

@svix-mman svix-mman changed the title Move SvixHttpClient to internal package Create new internal Go lib Apr 15, 2025
@svix-mman
Copy link
Contributor Author

Why add this to the SDK, rather than the terraform package?

I kinda want to dog food the SDK, it feels bad to generate an extra lib.
Is there any downside to create this internal api?

@svix-jplatte
Copy link
Member

I was talking about only generating code there for the internal stuff. I don't see a big downside to this approach, one thing is that it doesn't allow us to later remove the hidden stuff from this repo, but that doesn't seem so important.

svix-jplatte
svix-jplatte previously approved these changes Apr 15, 2025
Copy link
Member

@svix-jplatte svix-jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the other approach might be too much extra work 🤷

@svix-mman
Copy link
Contributor Author

I was talking about only generating code there for the internal stuff. I don't see a big downside to this approach, one thing is that it doesn't allow us to later remove the hidden stuff from this repo, but that doesn't seem so important.

I don't like the idea of exposing the internal workings (executeRequest, etc...) of the SDK publicly

@svix-jplatte
Copy link
Member

Don't need to do that, could just duplicate.

Base automatically changed from mendy/prep-go-lib to main April 15, 2025 13:44
@svix-mman svix-mman dismissed svix-jplatte’s stale review April 15, 2025 13:44

The base branch was changed.

@svix-mman svix-mman requested a review from svix-jplatte April 15, 2025 13:46
@svix-mman svix-mman merged commit 1be4f2b into main Apr 15, 2025
11 checks passed
@svix-mman svix-mman deleted the mendy/add-internal-go-lib branch April 15, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants