Skip to content

python: Enable configuring proxies in SvixOptions #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svix-mman
Copy link
Contributor

@svix-mman svix-mman commented May 19, 2025

ref: #1926

Adds a new proxy field to SvixOptions, to be used as both http and https proxy

@svix-mman svix-mman requested a review from a team as a code owner May 19, 2025 12:41
@svix-mman svix-mman force-pushed the mendy/add-py-proxy branch from 51426b4 to 6f5b256 Compare May 19, 2025 12:44
@svix-jplatte
Copy link
Member

Adds a new proxy field to SvixOptions, to be used as both http and httpx proxy

You mean both http and https? Also, why? AFAIU #1926 asks for being able to configure both as their own thing, and I could there being use cases for only setting one of the two.

@svix-mman
Copy link
Contributor Author

You mean both http and https?

Yes 😅

Also, why? AFAIU #1926 asks for being able to configure both as their own thing, and I could there being use cases for only setting one of the two.

If they are using our client, they are talking to https:// api.svix.com, so we don't need to support both

@svix-jplatte
Copy link
Member

Then we should be naming this https_proxy and leaving out HTTP proxy support for now, IMO :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants