Change layout of rust struct/imports/func params to vertical#2122
Draft
svix-mman wants to merge 2 commits into
Draft
Change layout of rust struct/imports/func params to vertical#2122svix-mman wants to merge 2 commits into
svix-mman wants to merge 2 commits into
Conversation
f2f1046 to
4a30e3f
Compare
Contributor
Author
|
Not sure if I really want to do this, maybe I can generate nicely formatted code by hand 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purely a formatting change.
I added these 3 lines to the rustfmt config in the rust sdk and in the cli.
This makes all function calls, struct literal instantiation, imports, function prams to be formatted vertically. It's a little uglier, but I don't care so much about generated code 🤷
Part of my long term goal to not need rustfmt at all, will minimize the diff in an upcoming PR.