feat(acp): allow disabling update checks - #85
Open
codexvn wants to merge 1 commit into
Open
Conversation
codexvn
force-pushed
the
feat/disable-update-check
branch
from
July 22, 2026 12:23
10bb7c9 to
ba209f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
PI_ACP_CHECK_FOR_UPDATESenvironment variable to optionally skip Pi update checks during ACP session startup.Setting the variable to
falsepreventsbuildUpdateNotice()from running. When unset or set to any other value, the existing update-check behavior is preserved.Motivation
The update check executes
pi --versionand queries npm synchronously duringsession/new. In sandboxed or latency-sensitive environments, this adds unnecessary startup latency and may depend on network availability.Changes
buildUpdateNotice()whenPI_ACP_CHECK_FOR_UPDATES=false.Testing
Passed:
npm run typechecknpm run lintnpm run buildThe full test suite reports 86/88 passing on Windows. The two failures are existing path-separator assumptions in:
session-events.test.tssession-list-and-load.test.tsThe smoke script also has an existing Windows-specific
spawn npm/npm.cmdissue.