Skip to content

forward session update event - #89

Open
davidhewitt wants to merge 1 commit into
svkozak:mainfrom
davidhewitt:session-update
Open

forward session update event#89
davidhewitt wants to merge 1 commit into
svkozak:mainfrom
davidhewitt:session-update

Conversation

@davidhewitt

Copy link
Copy Markdown

This is somewhat related to #25 but is the minimal addition to pi-acp needed to implement my own auto-title extension. IMO the full auto-title feature doesn't belong in pi-acp so this is the only diff that's relevant.

@alberti42

Copy link
Copy Markdown

See also related #93 (comment)

@ninjaltd

Copy link
Copy Markdown

Verified this exact change end-to-end against Zed: with the session_info_changed case added to the event switch, a pi-side rename (via a pi.setSessionName() extension) now arrives in Zed live as session/updatesession_info_update with title set, without any client-side work.

This has been blocked waiting on a merge for two months now — several independent PRs (#60, #74, this one, #93) implement the same one-branch fix. Since this is the smallest and has a test, it would be great if it could get a review and merge so the others can close as duplicates. Happy to test anything you need on the Zed side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants