Improve findsources functionality #51
Conversation
|
@sachinshaji, can you please explain the current state of this PR? I see you marked it as draft, does it make sense already to review your changes? |
…ive GitLab deep search, and adapt search strategy based on different programming language
capycli/common/script_base.py
Outdated
| if exit_no_login: | ||
| print_red(" No SW360 server URL specified!") | ||
| sys.exit(ResultCode.RESULT_ERROR_ACCESSING_SW360) |
There was a problem hiding this comment.
Note that you could also catch SystemExit in the caller of login(). Not sure if we want an extra parameter for this. What do you think, @tngraf?
There was a problem hiding this comment.
I see no reason for an extra parameter.
@sachinshaji Please explain why this should be needed.
There was a problem hiding this comment.
As we have added the functionality to lookup the SW360 server(to find the already existing source code) for the capycli bom findsources command we need SW360 URL and TOKEN. If we don't add the exit_no_login paramerter to login the capycli bom findosurces will always search for SW360 URL and TOKEN and if we don't give, the command will fail/error out.
We have added the exit_no_login so that even the users doesn't give SW360 creds the capycli bom findsources will run successfully trying to find the source code from github(only skip the SW360 lookup).
There was a problem hiding this comment.
I stll do not see the need:
- Case 1: a token and a SW360 url have been given on the command line.
You can check that they are not emptry and then calllogin()=> noexit_no_loginneeded. - Case 2: neither token nor SW360 url have been given on the command line.
a) The user decided not to provide this information => user does not want to use SW360 information
=> do not call login => noexit_no_loginneeded.
b) You can mimik the behavior oflogin()and check if the information is available in the environment.
If is exists, pass it as parameter. If it does not exist you cannot login.
In either way noexit_no_loginneeded.
There was a problem hiding this comment.
Ok I will check this. Thanks for the detailed explanation.
|
@sachinshaji, can you please check the results of the unit tests here? It seems there are some errors and a warning that |
|
@gernot-h I will check the warning message we have. 'removesuffix' attribute is not present under string class in python 3.8. Is it fine to use that? |
As you only use that once in your code, I guess it's not justifying dropping Python 3.8 support for that. I think it should be easily replaceable by something like: |
|
@gernot-h The warning messages and errors are resolved. |
capycli/bom/findsources.py
Outdated
There was a problem hiding this comment.
Things to improve:
- Provide help text for the arguments
-t,-url - Improve text coverage
- Add type information (... mypy will come soon...)
There was a problem hiding this comment.
New commit in PR has been initiated with these comments addressed
Conduct source URL discovery using sw360 lookup, perform extensive GitLab deep search, and adapt search strategy based on diverse programming languages.