refactor how the size constraint is applied to a parameter#5080
Open
Mattias-Sehlstedt wants to merge 1 commit intoswagger-api:masterfrom
Open
refactor how the size constraint is applied to a parameter#5080Mattias-Sehlstedt wants to merge 1 commit intoswagger-api:masterfrom
Mattias-Sehlstedt wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Mattias-Sehlstedt
force-pushed
the
refactor-parameter-processor
branch
from
dc6c042 to
bb8559b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
I would like to pick up the inactive PR #4986, and I saw that there had been some feedback there from a maintainer. With this PR I have partially acted upon it by utilizing the new class that carries ConstraintAnnotation-logic (and I aim to introduce composed-annotation handling there too).
Further refactoring can be done to synchronize the behavior better with the
ModelResolver, but for that #5064 is needed, since it breaks out the sibling logic that is currently semi-duplicated between the two classes.Update: The functionality from #5064 is merged, but it does not align completely with how the
ParameterProcessorhandles OAS 3.0/OAS 3.1, thus that change is considered out of scope for this PR.Fixes:
Type of Change
Checklist
Screenshots / Additional Context