Fix Docker instructions / port mapping#5712
Open
pawelzar wants to merge 1 commit intoswagger-api:mainfrom
Open
Fix Docker instructions / port mapping#5712pawelzar wants to merge 1 commit intoswagger-api:mainfrom
pawelzar wants to merge 1 commit intoswagger-api:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the Docker Hub instructions for running Swagger Editor locally are misleading.
The current instruction:
maps host port 80 to container port 8080. However, Swagger Editor’s nginx actually serves the editor on port 80 inside the container - there is no custom nginx configuration to listen on 8080.
This PR:
it would be great to update the Docker Hub instructions as well to match this fix. I also noticed that the instruction has a broken link to
Importing your OpenAPI document.