fix: Rewrite nested whole document external refs to components (#1889) - #2385
Open
ewaostrowska wants to merge 1 commit into
Open
fix: Rewrite nested whole document external refs to components (#1889)#2385ewaostrowska wants to merge 1 commit into
ewaostrowska wants to merge 1 commit into
Conversation
ewaostrowska
force-pushed
the
issue-1889
branch
from
August 24, 2026 08:47
41e57d8 to
7dd94c5
Compare
…l component refs (#1889)
ewaostrowska
force-pushed
the
issue-1889
branch
from
August 25, 2026 08:26
7dd94c5 to
3130a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
When an external file referenced by an OAS document contains its own refs that point to other files as whole-document references (no
#fragment), the parser resolved the file path but never rewrote the$refto an internal component form. The resolved output kept raw file paths like../common/models/Product.yamlinstead of#/components/schemas/Product, making the resolved spec unusable for code generators and other consumers.Before: items.$ref stayed as an absolute file path
After: items.$ref is rewritten to an internal ref
The same bug affected
headers,links, andexamples.Fragment refs (
file.yaml#/components/schemas/X) were already handled correctly by the existing code and are not affected by this change.Fixes: #1889
Type of Change
Checklist
Screenshots / Additional Context