Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add debounce to textarea component to improve performance #10345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orck-adrouin
Copy link

Description

Wrap the textarea component with DebounceInput to improve performance when modifying text in the body of a request

Motivation and Context

My project has 500+ requests and typing in the body is slow because changing the body re-render everything on the page.
A PR (#5882) was created a few years ago to correct issue #5850 however it was abandoned.

Fixes #5850

How Has This Been Tested?

Manual testing and ran all tests.

I had to modify a few tests to call blur() on the body to force the debounce to trigger. I would have expected the tests to work without having to call blur() however I don't know enough about Cypress to know if this is normal.

Screenshots (if appropriate):

N/A

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Wrap the textarea component with DebounceInput to improve performance
when modifying text in the body of a request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue when typing text
1 participant