Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oas31): display file upload input when contentMediaType or contentEncoding is present #10412

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

glowcloud
Copy link
Contributor

Refs #9278

Implement layer 3 of #9278 (comment)

: schema.contentEncoding

return (
(contentMediaType && typeof contentMediaType === "string") ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(contentMediaType && typeof contentMediaType === "string") ||
(typeof contentMediaType === "string" && contentMediaType !== "") ||


return (
(contentMediaType && typeof contentMediaType === "string") ||
(contentEncoding && typeof contentEncoding === "string")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(contentEncoding && typeof contentEncoding === "string")
(typeof contentEncoding === "string" && contentEncoding !== "")

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add comment explaining the short-circuit mechanism + explicit non-empty string assertions.

@glowcloud glowcloud merged commit 2696730 into master Apr 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants