fix: escape vertical bar character in cURL (CMD) request snippets#10733
Open
slegarraga wants to merge 1 commit intoswagger-api:masterfrom
Open
fix: escape vertical bar character in cURL (CMD) request snippets#10733slegarraga wants to merge 1 commit intoswagger-api:masterfrom
slegarraga wants to merge 1 commit intoswagger-api:masterfrom
Conversation
The pipe character | was not being escaped in CMD curl snippets, causing Windows cmd.exe to interpret it as a command separator. Added .replace(/\|/g, "^|") to the escapeCMD function, which escapes | with a caret (^) following CMD escaping conventions. Fixes swagger-api#10540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10540
Problem
The vertical bar character
|in JSON request bodies was not being escaped incURL (CMD)request snippets. When pasting the generated command into Windowscmd.exe, the pipe is interpreted as a command separator, causing errors like:Fix
Added
.replace(/\|/g, "^|")to theescapeCMDfunction insrc/core/plugins/request-snippets/fn.js. This escapes|with a caret (^), following the same CMD escaping convention already used for^and newlines in the function.The replacement is placed after the caret escape (
^^) to avoid double-escaping.