fix(oas31): use transparent bg-color for accordion and expand buttons#10740
Open
baarde wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(oas31): use transparent bg-color for accordion and expand buttons#10740baarde wants to merge 1 commit intoswagger-api:masterfrom
baarde wants to merge 1 commit intoswagger-api:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
background-colortotransparentfor accordion and expand buttons when loading an OAS 3.1 spec.Motivation and Context
Currently, when loading an OAS 3.1 spec, the default button background color (
ButtonFace) is used for accordion and expand buttons.In Chrome,
ButtonFacehappens to be very close to the container background color, so the difference is not noticeable. In Safari, however, the issue is quite apparent.How Has This Been Tested?
npm run lint: No new problems.npm run lint-styles: No new problems.npm run test: All tests pass.npm run devhttps://raw.githubusercontent.com/readmeio/oas-examples/main/3.1/json/petstore.jsonScreenshots
Before
After
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests