Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support github.com/swaggo/swag/v2 #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martinyonatann
Copy link

@martinyonatann martinyonatann commented Feb 2, 2025

Describe the PR
add support github.com/swaggo/swag/v2

Relation issue
Address issue #126

Additional context
N/A

@martinyonatann martinyonatann changed the title add support swaggo v2 add support github.com/swaggo/swag/v2 Feb 2, 2025
@martinyonatann
Copy link
Author

please help to review @ubogdan

@ubogdan
Copy link
Contributor

ubogdan commented Feb 3, 2025

Merging this into the master branch will force everyone to generate the "doc" with swag v2. This will introduce breaking changes to all projects using v1 (echo-swagger).

@martinyonatann
Copy link
Author

Merging this into the master branch will force everyone to generate the "doc" with swag v2. This will introduce breaking changes to all projects using v1 (echo-swagger).

I don't think so. V1 is still using the existing handler, while V2 uses EchoWrapHandlerV3.

@martinyonatann
Copy link
Author

github.com/sv-tools/openapi only supports Go 1.21 or newer. Do we need to upgrade as well? I think 1.16 is too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants