Skip to content

fix: prefill PID offsets before uprobe attach #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swananan merged 1 commit into from
May 1, 2026
+3 −6
Merged

fix: prefill PID offsets before uprobe attach #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ghostscope/src/script/compiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ async fn create_and_attach_loader(
}

apply_pid_alias_for_session(session, compile_options);
// Populate PID-mode module offsets before attaching. Once the uprobe is
// attached, a running target can hit it immediately.
apply_cached_offsets_for_session_pid(session, compile_options);

if let Some(uprobe_offset) = config.uprobe_offset {
if let Some(ref function_name) = config.function_name {
Expand Down Expand Up @@ -450,9 +453,6 @@ pub async fn compile_and_load_script_for_tui(
.await
{
Ok(loader) => {
// Apply cached offsets for PID-mode lookups (if available).
apply_cached_offsets_for_session_pid(session, compile_options);

info!(
"✓ Successfully attached uprobe for trace_id {}",
config.assigned_trace_id
Expand Down Expand Up @@ -707,9 +707,6 @@ pub async fn compile_and_load_script_for_cli(
match create_and_attach_loader(config, session.attach_pid(), session, compile_options).await
{
Ok(loader) => {
// Apply cached offsets for PID-mode lookups (if available).
apply_cached_offsets_for_session_pid(session, compile_options);

info!(
"✓ Successfully attached uprobe for trace_id {}",
config.assigned_trace_id
Expand Down
Loading