Upcoming programming contests added #218
Conversation
|
Any update? |
| @@ -4,6 +4,7 @@ | |||
| 'book', | |||
| 'bye', | |||
| 'coin', | |||
| 'cpcontest', | |||
There was a problem hiding this comment.
Let's think of a better name.
There was a problem hiding this comment.
"contest" would be too generalized, other names are too big such as "programmingcontest" or something like that. So, I abbreviated "competitive programming" to "cp" here. Do you have any suggestion?
| output = {} | ||
| try: | ||
|
|
||
| r = requests.get('https://cpcontest-api.herokuapp.com/') |
There was a problem hiding this comment.
Is this your personal api? If yes, do you plan to maintain it (hosting, bug fixes, etc.)?
There was a problem hiding this comment.
Yes, this is my personal API and I am maintaining it. If I could find any alternative API, which is very well maintained and serves the purpose, I will update it.
| buttons.add_web_url(contest['Name'], contest['url']) | ||
| num -= 1 | ||
| if num == 0: | ||
| break |
There was a problem hiding this comment.
A better way to do this would be to specify this number in the API call itself.
modules/src/cpcontest.py
Outdated
| r = requests.get('https://cpcontest-api.herokuapp.com/') | ||
| data = r.json() | ||
|
|
||
| template = GenericTemplate() |
modules/src/cpcontest.py
Outdated
| @@ -0,0 +1,30 @@ | |||
| import requests | |||
| import os | |||
| r = requests.get('https://cpcontest-api.herokuapp.com/') | ||
| data = r.json() | ||
|
|
||
| buttons = ButtonTemplate() |
There was a problem hiding this comment.
F821 undefined name 'ButtonTemplate'
modules/tests/test_cpcontest.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| import modules | |||
|
|
|||
| def test_cpcontest(): | |||
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
|
@torquecoder Let's fix the tests please, one of the tests is failing, :) |
Adding feature of issue #164
Some of the sample queries are: