wiki module:added images in case of Disambiguation #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any Updates? |
swapagarwal
requested changes
Aug 17, 2017
modules/src/wiki.py
Outdated
| @@ -40,7 +39,7 @@ def process(input, entities): | |||
| } | |||
| } | |||
| buttons.add_postback('Wikipedia Summary', payload) | |||
| template.add_element(title=data.title, item_url=data.url, image_url=image_url, | |||
| template.add_element(title=data.title, item_url=data.url, image_url=data.images[0], | |||
There was a problem hiding this comment.
The images list might be empty. In that case, let's default to the current image_url.
|
@swapagarwal Please review sir |
|
Hey @aviral1701, I deployed this change to test it; but the output isn't that good. What do you think? |
|
@swapagarwal Ya result is not so good.May be we should stick with the wiki image only. |
|
Can we get the main wiki image using some other API? If not, let's drop this. |
|
@swapagarwal Hey, sorry for late response,was busy with my midterms. |
…senger pulling from the original repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.