Aww #316
Open
Aww #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapagarwal
requested changes
Oct 18, 2017
modules/src/aww.py
Outdated
| def process(input, entities): | ||
| output = {} | ||
|
|
||
| request = urllib2.Request('https://www.reddit.com/r/aww/top.json?count=N&after=t3_XXXXX', None, headers) |
There was a problem hiding this comment.
Can we use reddit's python library here?
|
I had no idea praw existed, great suggestion! |
swapagarwal
requested changes
Oct 21, 2017
modules/src/aww.py
Outdated
| data = urllib2.urlopen(request) | ||
| json_data = json.load(data) | ||
| reddit = praw.Reddit(client_id='hidrsV8C-QzMmQ', | ||
| client_secret='segvJkUHCUFquxCxqz5ml9-tlmE', |
There was a problem hiding this comment.
Yes I've put some thought into how to handle the secret, the Reddit bot is temporary and can be spun up again. I figured you would want to generate the secret yourself since you handle deployments.
What should I do from here? Would you hold the secret in a system variable that is accessed during production?
|
@vinceiv Yes, praw is awesome. Contributing to open-source is indeed a great way to learn! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aww module supplies a response of a random image pulled from r/aww in the HOT category.
User should be able to prompt module with such language: