Skip to content

Added new feature of Cricket #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shubhsherl
Copy link

@shubhsherl shubhsherl commented Mar 24, 2018

Changes proposed in this pull request:

-Proposed to add a new feature of Cricket-Livescores

Description

-sample queries "cricket", "Livescore Cricket","cricket score".

Fixes: #

@swapagarwal
Copy link
Owner

Thank you for taking the time to contribute! This is sincerely appreciated. 😇

(Powered by GitMate.io)

@swapagarwal
Copy link
Owner

Can you share a sample output that this module will give?

code.py Outdated
@@ -0,0 +1,88 @@
import json
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file needed?

@shubhsherl
Copy link
Author

Sorry about code.py, I forgot to delete that.

@shubhsherl
Copy link
Author

shubhsherl commented Mar 24, 2018

input: cricket
Output:
"1st Test
NZ vs ENG
NZ 233/4
ENG 58/10
NZ lead by 175 runs


3rd Test
RSA vs AUS
RSA 238/5
AUS 255/10
RSA lead by 294 runs


3rd ODI (ICC Championship match)
SLW vs PAKW
SLW 107/10
PAKW 215/9
Pak Women won by 108 runs


3rd ODI (ICC Championship match)
SLW vs PAKW
SLW 107/10
PAKW 215/9
Pak Women won by 108 runs


3rd One-day
NORTH vs SOUTH
SOUTH 204/10
NORTH 296/8
North won by 92 runs


<button ="Cricbuzz Live">
"

@shubhsherl
Copy link
Author

@swapagarwal is the changes in modules are fine to merge?

@shubhsherl
Copy link
Author

@swapagarwal, any suggestion over this module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants