Add experimental TraceTimingMiddleware and refine ASGI header typing in IMiddleware#5979
Draft
cobycloud wants to merge 2 commits into
Draft
Add experimental TraceTimingMiddleware and refine ASGI header typing in IMiddleware#5979cobycloud wants to merge 2 commits into
cobycloud wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Server-Timingmetrics for latency observability.Description
swarmauri_middleware_tracetimingwithTraceTimingMiddlewarethat registers viaComponentBaseand implementsMiddlewareBasehookson_scopeandon_send.TraceTimingMiddlewareextracts or generatestraceparent/tracestate, stores timing information on the requestscope, and writesserver-timing,timing-allow-origin, and trace headers onhttp.response.start; anedge_ms_gettercan be injected to include edge duration.HeaderCollectionhelper for case-insensitive ASGI header read/write and a_gen_trace_ids()helper to create complianttraceparentvalues.pkgs/pyproject.tomlto include the new experimental package and refactors the middleware interfaceIMiddlewaretyping by introducingHeader: TypeAlias,Headers: TypeAlias, and updatingMessage.headersto useHeaders.Testing
pytest pkgs/experimental/swarmauri_middleware_tracetiming -q, executing unit tests intests/unitand integration tests intests/i9n, and all tests passed.test_import_packagewhich succeeded.Codex Task