Skip to content

fix: credential-env reads cred.encryptedKey (not cred.encrypted) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siglimumuni wants to merge 1 commit into from
Closed

fix: credential-env reads cred.encryptedKey (not cred.encrypted) #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lib/server/session-tools/credential-env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function buildCredentialEnv(credentialIds: string[]): CredentialEnv {
const env: Record<string, string> = {}
const secrets: string[] = []

const allCredentials = loadCredentials() as Record<string, Credential & { encrypted?: string }>
const allCredentials = loadCredentials() as Record<string, Credential & { encryptedKey?: string }>

for (const credId of credentialIds) {
const cred = allCredentials[credId]
Expand All @@ -45,8 +45,12 @@ export function buildCredentialEnv(credentialIds: string[]): CredentialEnv {
continue
}

// Decrypt the stored key
const encrypted = cred.encrypted
// Decrypt the stored key — credentials persist the ciphertext under
// `encryptedKey` (see createCredentialRecord in storage.ts; matching
// reads in connector-lifecycle, chatroom-helpers, daemon-state, etc.).
// Previously this file read `cred.encrypted`, which is never set, so
// credential injection silently no-op'd for every execute tool call.
const encrypted = cred.encryptedKey
if (!encrypted || typeof encrypted !== 'string') {
log.warn(TAG, `Credential has no encrypted value: ${credId}`)
continue
Expand Down
Loading