Excessively long link warning - #229
Open
davmillar wants to merge 4 commits into
Open
Conversation
davmillar
commented
Aug 16, 2026
davmillar
commented
Contributor
- Adds a warning popup when exporting a link and it's very long -- likely to trigger the "URI too long" error.
- Adds a setting to the Settings popup and the export popup allowing the warning to be turned off.
- Cleanup of a few settings-related handlers.
- Cleanup/fix load method to parse URLs that don't contain "penpa-edit" to allow local dev URLs to load more easily.
Added new user setting to disable the warning if desired. Added helper to settings area to clean up parsing behavior. Warning includes translations done by Duck Duck Go. Includes new io.js file for future abstraction of save and load code.
Change to the load functionality allows local development to load URLs without penpa-edit in the URL.
Contributor
Author
|
Resolves #227. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.