fix(cli): Clone config instead of updating it#106
fix(cli): Clone config instead of updating it#106CodeMan62 wants to merge 8 commits intoswc-project:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 345edc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I rebased to get CI fixed. Let's see how it goes |
|
i think it is failing |
|
Can you fix it? The CI passes on the main branch. |
I will try to fix it and create a PR |
|
I meant you should fix CI of this PR |
|
Sorry i misunderstood give me some time let me fix |
|
@kdy1 the CI fixed for now but i want to point out that when we do commit the type of |
kdy1
changed the title
packages/cli/src/swc/dir.ts
Outdated
| ); | ||
| } | ||
|
|
||
| await initialCompilation(clonedCliOptions, clonedSwcOptions, callbacks); |
There was a problem hiding this comment.
ahh, you're right i think i made a mistake i am fixing
| clonedSwcOptions, | ||
| callbacks | ||
| ); | ||
| return watcher; |
|
@kdy1 @CodeMan62 is there any holdup on this one? |
|
Yeah, the review is not reflected, and there is too much AI slop. |
3 participants
closes #97