fix(jest): Use greatest known jsc.target instead of least#99
Merged
kdy1 merged 2 commits intoswc-project:mainfrom May 30, 2025
Merged
fix(jest): Use greatest known jsc.target instead of least#99kdy1 merged 2 commits intoswc-project:mainfrom
jsc.target instead of least#99kdy1 merged 2 commits intoswc-project:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3ee09e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
everett1992
commented
May 5, 2025
everett1992
force-pushed
the
main
branch
2 times, most recently
from
f5a0f34 to
00494c2
Compare
kdy1
reviewed
May 29, 2025
kdy1
reviewed
May 29, 2025
Member
There was a problem hiding this comment.
Can you revert this change? Is it necessary?
Contributor
Author
There was a problem hiding this comment.
Before this change checks were failing because CI could not install with the frozen lockfile. I'll rebase and revert in case that fixes it.
Member
|
Can you rebase? |
I noticed that code coverage was different between node 20 and 22 when using @swc/jest and tracked it back to swc falling back to es2018 for unknown node versions. This change makes @swc/jest use the target of any lower node version Fixes swc-project#98
kdy1
approved these changes
May 30, 2025
kdy1
changed the title
jsc.target instead of least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that code coverage was different between node 20 and 22 when using @swc/jest and tracked it back to swc falling back to es2018 for unknown node versions.
This change makes @swc/jest use the target of any lower node version
Fixes #98