Skip to content

refactor(es/ast)!: Add body_ctxt to Switch - #12065

Open
Austaras wants to merge 2 commits into
swc-project:mainfrom
Austaras:main
Open

refactor(es/ast)!: Add body_ctxt to Switch#12065
Austaras wants to merge 2 commits into
swc-project:mainfrom
Austaras:main

Conversation

@Austaras

@Austaras Austaras commented Jul 22, 2026

Copy link
Copy Markdown
Member

Description:

This shouldn't change anything but downstream user.

BREAKING CHANGE:

Related issue (if exists):

@Austaras
Austaras requested review from a team as code owners July 22, 2026 07:56
@changeset-bot

changeset-bot Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d2214d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 22, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df6e27aa1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Comment thread crates/swc_ecma_compat_es2015/src/generator.rs
Comment thread crates/swc_ecma_transforms_base/src/resolver/mod.rs
@codspeed-hq

codspeed-hq Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 189 untouched benchmarks
⏩ 61 skipped benchmarks1

Comparing Austaras:main (d2214d7) with main (1e3ed5c)

Open in CodSpeed

Footnotes

  1. 61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

kdy1
Donny/강동윤 (kdy1) reviewed Jul 22, 2026
View reviewed changes
Comment thread crates/swc_ecma_ast/src/stmt.rs
#[cfg_attr(feature = "shrink-to-fit", derive(shrink_to_fit::ShrinkToFit))]
pub struct SwitchStmt {
pub span: Span,
pub body_ctxt: SyntaxContext,

@kdy1 Donny/강동윤 (kdy1) Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an Wasm-breaking change, so I'll merge this along with different Wasm breaking PRs

@Austaras Austaras Jul 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other PR in mind?

@kdy1 Donny/강동윤 (kdy1) Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11803 and #11905

@magic-akari magic-akari Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was referenced Jul 23, 2026
Open
Open
@kdy1 Donny/강동윤 (kdy1) changed the title mod(es/ast): Add body_ctxt to Switch refactor(es/ast)!: Add body_ctxt to Switch Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magic-akari magic-akari magic-akari left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@kdy1 Donny/강동윤 (kdy1) kdy1 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Austaras @magic-akari @kdy1