You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes two soundness issues in hstr where mutable byte references were formed over uninitialized storage.
Use an initialized 64-byte stack buffer in Atom::from_mutated_str, retaining the stack fast path and heap fallback for longer strings.
Encode WTF-8 code points through Vec::spare_capacity_mut() and MaybeUninit::write, updating the vector length only after the exact encoded byte count is initialized.
Document the safety invariants for retained unsafe operations.
Add focused regression coverage for short, 64-byte, and over-64-byte ASCII case conversion and one- through four-byte code-point appends, including an unpaired surrogate.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes two soundness issues in
hstrwhere mutable byte references were formed over uninitialized storage.Atom::from_mutated_str, retaining the stack fast path and heap fallback for longer strings.Vec::spare_capacity_mut()andMaybeUninit::write, updating the vector length only after the exact encoded byte count is initialized.Validation:
cargo test -p hstrcargo fmt --allcargo clippy --all --all-targets -- -D warningsRelated issue (if exists):
Closes #12083