Skip to content

Manually update workflows to docker versions to test#652

Merged
froggleston merged 3 commits intoswcarpentry:mainfrom
froggleston:main
Jun 3, 2025
Merged

Manually update workflows to docker versions to test#652
froggleston merged 3 commits intoswcarpentry:mainfrom
froggleston:main

Conversation

@froggleston
Copy link
Copy Markdown
Contributor

@froggleston froggleston commented Jun 2, 2025

This PR will replace the current Workbench workflows with dockerised versions to improve a range of maintenance factors, and deliver more reproducible builds.

Addresses #650

This is still in testing phase, and can be safely reverted if issues arise.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2025

ℹ️ Modified Workflows

This pull request contains modified workflow files and no preview will be created.

Workflow files modified:

  • .github/workflows/README.md
  • .github/workflows/docker_apply_cache.yaml
  • .github/workflows/docker_build_deploy.yaml
  • .github/workflows/docker_pr_receive.yaml
  • .github/workflows/pr-close-signal.yaml
  • .github/workflows/pr-comment.yaml
  • .github/workflows/pr-post-remove-branch.yaml
  • .github/workflows/pr-preflight.yaml
  • .github/workflows/pr-receive.yaml
  • .github/workflows/sandpaper-main.yaml
  • .github/workflows/sandpaper-version.txt
  • .github/workflows/update-cache.yaml
  • .github/workflows/update-workflows.yaml

If this is not from a trusted source, please inspect the changes for any malicious content.

Copy link
Copy Markdown
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick check to avoid additional commits, but you might have done this already:

I suspect the swcarpentry GH organization restricts which actions can be used.

Do you need to move froggleston/actions as a branch in carpentries/actions or enable actions from your account? (no extra commit required for this second option)

@froggleston
Copy link
Copy Markdown
Contributor Author

Just a quick check to avoid additional commits, but you might have done this already:

I suspect the swcarpentry GH organization restricts which actions can be used.

Do you need to move froggleston/actions as a branch in carpentries/actions or enable actions from your account? (no extra commit required for this second option)

I've merged in the changes to the main carpentries actions - they're non-breaking for existing workflows.

Copy link
Copy Markdown
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if you are still editing things but I'm approving this PR so feel free to merge when convenient for you.

@froggleston
Copy link
Copy Markdown
Contributor Author

Thanks @Bisaloo ! Here we go .... 🤞

@froggleston froggleston merged commit 2a18a63 into swcarpentry:main Jun 3, 2025
6 checks passed
github-actions Bot pushed a commit that referenced this pull request Jun 3, 2025
Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 3, 2025
Auto-generated via `{sandpaper}`
Source  : 34b726c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-06-03 18:43:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
@froggleston
Copy link
Copy Markdown
Contributor Author

@Bisaloo Looks good! There were a couple of minor issues but none that stopped the build from working, just things I'll need to document and improve (the build is quite verbose as there are more checks now than before).

@Bisaloo
Copy link
Copy Markdown
Member

Bisaloo commented Jun 4, 2025

It's not really a problem in this specific case but might(?) be in other lessons: the png files created by rmarkdown are larger than what they used to be. I can't pinpoint the exact reason for this but my intuition would be:

  • either pngquant used to be present and is no longer there. Knitr has a hook to automatically compress png as they are rendered if pngquant is installed and the hook is enabled.
  • or the graphical backend is different. In particular, the ragg package probably produces png smaller than Cairo. I'm not sure which one was used before and which one is used now.

Again, this may not warrant a deep dive now but it's probably good to keep in the back of your mind.

@froggleston
Copy link
Copy Markdown
Contributor Author

That's great feedback - thank you! I can add pngquant to the docker image for the next release. I'm not doing anything with any internals, so haven't switched any backend rendering specifically.

github-actions Bot pushed a commit that referenced this pull request Jun 10, 2025
Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 10, 2025
Auto-generated via `{sandpaper}`
Source  : 3d90a20
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-06-10 00:25:04 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 17, 2025
Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 17, 2025
Auto-generated via `{sandpaper}`
Source  : 9c03d11
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-06-17 12:38:22 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 24, 2025
Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
github-actions Bot pushed a commit that referenced this pull request Jun 24, 2025
Auto-generated via `{sandpaper}`
Source  : eb0096e
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-06-24 00:25:09 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 2a18a63
Branch  : main
Author  : Robert Davey <robertdavey@carpentries.org>
Time    : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main

Manually update workflows to docker versions to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants