Manually update workflows to docker versions to test#652
Manually update workflows to docker versions to test#652froggleston merged 3 commits intoswcarpentry:mainfrom froggleston:main
Conversation
ℹ️ Modified WorkflowsThis pull request contains modified workflow files and no preview will be created. Workflow files modified:
If this is not from a trusted source, please inspect the changes for any malicious content. |
Bisaloo
left a comment
There was a problem hiding this comment.
Just a quick check to avoid additional commits, but you might have done this already:
I suspect the swcarpentry GH organization restricts which actions can be used.
Do you need to move froggleston/actions as a branch in carpentries/actions or enable actions from your account? (no extra commit required for this second option)
I've merged in the changes to the main carpentries actions - they're non-breaking for existing workflows. |
Bisaloo
left a comment
There was a problem hiding this comment.
I'm not 100% sure if you are still editing things but I'm approving this PR so feel free to merge when convenient for you.
|
Thanks @Bisaloo ! Here we go .... 🤞 |
Auto-generated via `{sandpaper}`
Source : 34b726c
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-03 18:43:05 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 2a18a63
Branch : main
Author : Robert Davey <robertdavey@carpentries.org>
Time : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main
Manually update workflows to docker versions to test
|
@Bisaloo Looks good! There were a couple of minor issues but none that stopped the build from working, just things I'll need to document and improve (the build is quite verbose as there are more checks now than before). |
|
It's not really a problem in this specific case but might(?) be in other lessons: the png files created by rmarkdown are larger than what they used to be. I can't pinpoint the exact reason for this but my intuition would be:
Again, this may not warrant a deep dive now but it's probably good to keep in the back of your mind. |
|
That's great feedback - thank you! I can add pngquant to the docker image for the next release. I'm not doing anything with any internals, so haven't switched any backend rendering specifically. |
Auto-generated via `{sandpaper}`
Source : 3d90a20
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-10 00:25:04 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 2a18a63
Branch : main
Author : Robert Davey <robertdavey@carpentries.org>
Time : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main
Manually update workflows to docker versions to test
Auto-generated via `{sandpaper}`
Source : 9c03d11
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-17 12:38:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 2a18a63
Branch : main
Author : Robert Davey <robertdavey@carpentries.org>
Time : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main
Manually update workflows to docker versions to test
Auto-generated via `{sandpaper}`
Source : eb0096e
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-24 00:25:09 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 2a18a63
Branch : main
Author : Robert Davey <robertdavey@carpentries.org>
Time : 2025-06-03 18:33:25 +0000
Message : Merge pull request #652 from froggleston/main
Manually update workflows to docker versions to test
This PR will replace the current Workbench workflows with dockerised versions to improve a range of maintenance factors, and deliver more reproducible builds.
Addresses #650
This is still in testing phase, and can be safely reverted if issues arise.