Contrast changes to join now for dark mode#123
Merged
Advayp merged 5 commits intoswecc-uw:mainfrom Jan 5, 2026
Merged
Conversation
…h the background and box
…trast was making it hard to read
Contributor
|
not sure why the action is failing, seems unrelated to your changes though |
Advayp
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Justin Hernandez Tovalin
Changes Made
1. "Join the Discord" Button (
.link-boxes,a.link-boxes) - Dark ModeProblem: The "Join the discord" button had poor contrast in dark mode. The button text was using
var(--text-header-color)which resolves to a very light color (#ffeaee) in dark mode, making it nearly invisible against the light gray button background (#e5e2ed). Additionally, the hover state had poor contrast.Solution:
.dark-mode a.link-boxes { color: #000; }to force black text in dark mode for proper contrast against the light backgroundbody.dark-mode .link-boxes:hoverandbody.dark-mode a.link-boxes:hoverrules with:#2a1f4a(darker purple for visual feedback)#f5eaff(light purple for contrast)!importantflags andbody.dark-modeselector for higher specificity to override base hover stylesImpact: The "Join the discord" button now has readable black text in dark mode, and the hover state provides clear visual feedback with proper contrast.
2. Next/Previous Buttons (
.click-button) - Dark Mode Base StateProblem: The Next and Previous buttons had light text color (
#e5e2ed) which provided poor contrast against the purple button background (#9c7ef3) in dark mode, making the text difficult to read.Solution:
.dark-mode .click-button { color: #000000; }rule (Lines 124-127)Impact: Button text is now clearly readable in dark mode and meets accessibility contrast requirements.
3. Next/Previous Buttons (
.click-button) - Dark Mode Hover StateProblem:
.click-button:hover) was applying in dark mode, causing conflictsSolution:
.click-button:hovertobody:not(.dark-mode) .click-button:hoverto prevent it from applying in dark modebody.dark-mode .click-button:hoverrule with:#9c7ef3(same as base color - no visual change on hover)#ffffff(white for maximum contrast)!importantflags andbody.dark-modeselector for higher specificityImpact: Hover state now works correctly in dark mode with readable white text, and light mode hover no longer conflicts.
4. "Thanks for Joining!" Box (
.thanks-box,.thanks-message) - Dark ModeProblem: The "Thanks for Joining!" message box had text color that was too similar to the light purple background (
#beb8eb80), making the text nearly invisible in dark mode.Solution:
.dark-mode .thanks-boxrule (Lines 186-190) with:#3d3061(darker purple for better contrast)var(--text-subtitle-color)which resolves to#beb8eb(matches the step text color above for visual consistency)Impact: The "Thanks for Joining!" message is now clearly readable in dark mode and maintains visual consistency with the step labels above it.