made the officer application button easy to change#131
Merged
JTovalin10 merged 1 commit intomainfrom Jan 7, 2026
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit d2bba06): https://swecc-org--pr131-jtovalin-removing-of-g73eiy9v.web.app (expires Tue, 13 Jan 2026 09:15:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5f37faadb442ba8fa7c35b669f11be1475c4891 |
Contributor
|
does this close #130 ? |
Contributor
Author
|
yes this closes 130 |
Contributor
Author
|
wait no, the website has officer applications for 2025-2026 right now so this is to remove that and easily change the year |
Advayp
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Justin Hernandez Tovalin
Added a flag to the officer application button so its easy to disable and enable. Additionally, I made the year easy to change with APPLICATION_YEAR at the top of the function
Why are these changes important/necessary?
makes the codebase easier to adjust and we need to disable the officer application (i think)
(If applicable) Screenshots of your changes. Providing an “old vs. new” comparison would be great!