Conversation
…ions into map-authors
…motions into signature-test
date coverage test
…ons into title-test
Contributor
|
Failing check because of pyriksdagen.utils import version_number_is_valid? |
annotate title strings
…-motions into annotate-titles
annotate titles
mandlilaast
approved these changes
Sep 29, 2025
Contributor
mandlilaast
left a comment
mandlilaast
left a comment
There was a problem hiding this comment.
Great work overall! Just a few notes (probably repeating myself but, just in case):
- “Lika lydande…” – This phrase should not be part of any motion title in the sampled cases (e.g.,
data/1962/mot-1962--fk--00552.xml,data/1953/mot-1953--fk--00110.xml). It can be safely ignored when extracting titles. mot-1946--fk--00217.xml(diff at line 148) – The content in the PDF (pages 3–4: link, link) refers to attachments (“bilagor”), not the actual motion title. So we shouldn’t classify it as the title, in my opinion....?- Split titles over multiple segments – Some motion titles span multiple
<p>elements (e.g.,mot-1907--fk--00042.xml). Right now, only one segment is classified as the title, although the title itself spans across those two segments.
Otherwise, everything looks really solid! 16/17 considering points 1 and 3 as improvement and not mistakes.
add goldstandard quality estimate test and results...
Contributor
|
Still failing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.