Skip to content

Investigate cmake issue #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

Investigate cmake issue #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88a908b
Investigate cmake issue
martin4861 Sep 5, 2025
700870a
Fix cmake version, because of some rust dependencies
martin4861 Sep 8, 2025
fc59d0b
Fix spelling_wordlist for newly added feature
martin4861 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Build docker image
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
fetch-depth: 0
submodules: recursive
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ RUN \
python3.10 python3.10-dev python3.10-distutils \
python3.11 python3.11-dev python3.11-distutils \
dpkg-dev \
cmake \
cmake-data=3.16.3-1ubuntu1.20.04.1 \
Copy link
Contributor Author

@martin4861 martin4861 Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt install cmake will install cmake 4.x which breaks the cmake build, because of some incompatibilities. Fixing it to cmake 3.16 is a short term fix, a proper fix will be done separately.

cmake=3.16.3-1ubuntu1.20.04.1 \
libjson-perl \
libdigest-crc-perl \
&& curl -sSL https://get.haskellstack.org/ | sh \
Expand Down
1 change: 1 addition & 0 deletions python/docs/source/spelling_wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
0x00BD
AE
Acq
BBA
BBD
keyframe
BCD
Expand Down
Loading