Skip to content

Reverts let chain usage because not supported until rust 2024 #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

Reverts let chain usage because not supported until rust 2024 #1525

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebb1947
Reverts let chain usage because not supported until rust 2024
pcrumley Oct 28, 2025
ab68866
i should have tested locally
pcrumley Oct 28, 2025
662b527
bump base64
pcrumley Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions rust/sbp/src/sbp_string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ impl SbpString<Vec<u8>, DoubleNullTerminated> {
data: impl Into<Vec<u8>>,
) -> Result<Self, DoubleNullTerminatedError> {
let vec = data.into();
if let [.., two, one] = vec.as_slice()
&& two == &0
&& one == &0
{
return Ok(SbpString::new(vec));
if let [.., &two, &one] = vec.as_slice() {
if two = 0 && one == 0 {
return Ok(SbpString::new(vec));
}
};
Err(DoubleNullTerminatedError)
}
Expand Down
Loading