Skip to content

[C/C++] CMake: Set include install interface to include #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

[C/C++] CMake: Set include install interface to include #1535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76f6bb2
Set install iface to `include` directory not `lib`
ethanmusser Nov 13, 2025
c28225e
Merge branch 'master' into ethanmusser/bug/1532-install-interface-libdir
martin4861 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ target_include_directories(sbp
PUBLIC
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>
Copy link
Contributor

@martin4861 martin4861 Nov 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether this line is still needed?

Copy link
Contributor Author

@ethanmusser ethanmusser Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason you would need it. But I didn't want to break any of your existing tooling/setups that might depend on it in an unexpected way.

$<INSTALL_INTERFACE:${CMAKE_INSTALL_LIBDIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
Copy link
Contributor

@martin4861 martin4861 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/include
)
Expand Down
Loading