Skip to content

Conversation

@BillyONeal
Copy link

@BillyONeal BillyONeal commented Nov 13, 2025

Description

Put the correct include directory in the installed CMake configs.

The headers are installed to CMAKE_INSTALL_INCLUDEDIR here:

INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)
install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/libsbp/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/libsbp)
but the target_include_directories uses CMAKE_INSTALL_LIBDIR.

This patch originally authored by @ethanmusser in microsoft/vcpkg#48274

@swift-nav/algint-team

API compatibility

Does this change introduce a API compatibility risk?

No.

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

N/A

JIRA Reference

N/A

@BillyONeal BillyONeal requested a review from a team as a code owner November 13, 2025 22:46
@ethanmusser
Copy link
Contributor

@BillyONeal One step ahead of ya! #1535

@BillyONeal BillyONeal closed this Nov 13, 2025
@BillyONeal
Copy link
Author

BillyONeal commented Nov 13, 2025

@BillyONeal One step ahead of ya! #1535

Ah, I was looking for CMAKE_Xxx in the recent PRs so I missed it 😅. Closed in favor of yours, but added the location where the matching name comes from as a comment

@BillyONeal BillyONeal deleted the headers branch November 13, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants