Proxy URL support, gzip support, tailLines parameter on log requests, and some other minor tweaks
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ewilken Hey there, thanks a lot for the PR. You don't need to split it into separate ones. But I'll nitpick a little bit 😜 |
iabudiab
reviewed
Apr 13, 2025
…ome `KubeConfig` child structs
|
Nice, thanks 👍 |
|
Amazing! Thank you very much for the super quick review and release! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of tweaks that I've been running in production on Nautik for some time. Please let me know if you'd prefer getting them upstreamed as separate PRs instead of having them all cramped into one. In case it's okay like this, this PR does the following:
tailLinesparameter to the log request to be able to limit the number of lines requested from the server just like the upstream client does.RequestBuilderwhere a path was overwritten where it should have been appended. This became apparent with users using Rancher, where the base path already had a/in it. This change fixed it for all types of clusters, Rancher or not, but please let me know if I'm missing something here.doesNotExistvariant toLabelSelectorRequirement, akin to the upstream "DoesNotExist" variant on selectors.installHint,provideClusterInfoandinteractiveModefields toExecConfig.ExecCredentialpublic, as we need it to roll our own exec implementation that is probably too messy to ever be upstreamed.ClusterandAuthInfoand makeCluster,AuthInfo,AuthProviderConfig,ExecConfigandExecEnvVarconform toHashableandEquatable, as we need to initialize and compare them in different places on the app. I hope this makes sense to upstream and doesn't interfere with anything you have in mind. Otherwise, please just let me know and I'll keep it downstream.