Allow using GITHUB_TOKEN downstream #89
Conversation
|
@shahmishal I've tested this on my fork of vscode-swift https://github.com/award999/vscode-swift/actions/runs/13144430476. It does allow us to download the artifact for the sake of testing the extension we may ship. https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token outlines the default permissions. |
Looking at https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context the `github.token` is only available withins the `steps`. Of the common workflow, but the jobs extending it do not have access. The vscode-swift extension publishes a build of the extension in a separate job, and we want to be able to download it within the common workflow so we can test what is actually might be released.
| - name: Provide token | ||
| if: ${{ inputs.needs_token }} | ||
| run: | | ||
| echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
I wonder if something like this at call sites would do what you want:
uses: path/to/my/ci-file
+ secrets: inheritThere was a problem hiding this comment.
That didn't work unfortunately. secrets.GITHUB_TOKEN was empty
There was a problem hiding this comment.
Actually it wasn't the fact it was empty, secrets.GITHUB_TOKEN causes an error
and then github.secrets.GITHUB_TOKEN doesn't cause an error but is empty. And yes secrets is set to inherit
Looking at https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context the
github.tokenis only available withins thesteps. Of the common workflow, but the jobs extending it do not have access. The vscode-swift extension publishes a build of the extension in a separate job, and we want to be able to download it within the common workflow so we can test what is actually might be released.