Skip to content

[windows] fix flaky linker error when building LLDB #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: stable/20240723
Choose a base branch
from
Open

[windows] fix flaky linker error when building LLDB #10613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d159c
[windows] fix flaky linker error when building LLDB
charles-zablit May 2, 2025
23213ee
fixup! [windows] fix flaky linker error when building LLDB
charles-zablit May 2, 2025
a715cc1
make comment more explicit
charles-zablit May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lldb/source/API/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,6 @@ add_lldb_library(liblldb SHARED ${option_framework}
lldbValueObject
lldbVersion
${LLDB_ALL_PLUGINS}
## BEGIN SWIFT
${SWIFT_ALL_LIBS}
## END SWIFT
LINK_COMPONENTS
Support

Expand Down
1 change: 1 addition & 0 deletions lldb/source/Plugins/Language/Swift/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ add_lldb_library(lldbPluginSwiftLanguage PLUGIN
lldbPluginTypeSystemSwift
swiftAST
swiftClangImporter
swiftCore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here that this works around an issue on windows and maybe even ifdef this so we only do this on windows?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

clangAST

LINK_COMPONENTS
Expand Down