🍒 [APINotes] Avoid duplicate attributes when fields instantiate class templates #12051
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplates (llvm#173386) If a C++ class template `A` is annotated via API Notes and another class `B` has a field of type `A`, we would apply the attributes from the API Notes twice. This happened during `ActOnFields`, so this change makes sure we stop processing API Notes for class template instantiations in this function. rdar://166179307
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Jan 2, 2026
egorzhdan
approved these changes
Jan 2, 2026
compnerd
approved these changes
Jan 2, 2026
Author
|
@swift-ci please test |
Author
|
@swift-ci please test macos |
Author
|
@swift-ci please test macOS |
ravikandhadai
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a C++ class template
Ais annotated via API Notes and another classBhas a field of typeA, we would apply the attributes from the API Notes twice. This happened duringActOnFields, so this change makes sure we stop processing API Notes for class template instantiations in this function.rdar://166179307
(cherry-picked from 1ab9889)