[lldb] Handle not being able to read a file in the SourceManager #12058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m#174346) Even if a file has a valid modification time, it's possible that reading the data fails. The SourceManager wasn't accounting for that, which would result in a crash due to an unchecked read from a null `data_sp`. We were seeing the issue when trying to read from a buggy virtual file system, but presumably the same thing can happen with a poorly timed unmount of a drive. rdar://166414707 (cherry picked from commit a73de98)
Author
|
@swift-ci test |
Author
|
@swift-ci test macos |
fredriss
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if a file has a valid modification time, it's possible that reading the data fails. The SourceManager wasn't accounting for that, which would result in a crash due to an unchecked read from a null
data_sp.We were seeing the issue when trying to read from a buggy virtual file system, but presumably the same thing can happen with a poorly timed unmount of a drive.
rdar://166414707
(cherry picked from commit a73de98)