[clang][deps] Only disable app extension without PCHs (#207049) 🍒#13292
Open
jansvoboda11 wants to merge 1 commit into
Open
[clang][deps] Only disable app extension without PCHs (#207049) 🍒#13292jansvoboda11 wants to merge 1 commit into
jansvoboda11 wants to merge 1 commit into
Conversation
PR llvm#200041 disabled application extension during scanning to increase module cache reuse. To keep the build semantics intact, the setting was preserved for the compile steps. When scanning with an explicitly-built PCH, this triggers a mismatch error in `ASTReader`: ``` error: Objective-C App Extension was enabled in precompiled file 'X.pch' but is currently disabled ``` This PR fixes this by only performing the optimization for non-PCH compiles, adds a test, and a FIXME outlining how this optimization could be applied even for compiles with PCHs. rdar://180978125 (cherry picked from commit 066f7cb)
Author
|
@swift-ci please test |
Author
|
@swift-ci please test llvm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR llvm#200041 disabled application extension during scanning to increase module cache reuse. To keep the build semantics intact, the setting was preserved for the compile steps. When scanning with an explicitly-built PCH, this triggers a mismatch error in
ASTReader:This PR fixes this by only performing the optimization for non-PCH compiles, adds a test, and a FIXME outlining how this optimization could be applied even for compiles with PCHs.
rdar://180978125
(cherry picked from commit 066f7cb)