🍒 [next] [swift/cxx-interop] Move swift/bridging header to clang resource dir and suffix it with .h#13298
Open
j-hui wants to merge 2 commits into
Open
🍒 [next] [swift/cxx-interop] Move swift/bridging header to clang resource dir and suffix it with .h#13298j-hui wants to merge 2 commits into
j-hui wants to merge 2 commits into
Conversation
The swift/bridging header provides annotation macros (e.g., SWIFT_SHARED_REFERENCE, SWIFT_COMPUTED_PROPERTY) for C++ code that interoperate with Swift. Previously, this header was shipped in the Swift toolchain's usr/include, which is not part of Clang's default search paths in the OSS toolchain, which forced users to manually pass -I flags to find the header. By placing it in Clang's resource directory, the header is automatically discoverable by both clang and swift (via its embedded Clang instance), since both already search <clang-resource-dir>/include by default. rdar://136716355 (cherry picked from commit c19415a)
Some SWIFT_* annotation macros are usable from C and ObjC, not just C++. Rename the extensionless header to swift/bridging.h, and keep around swift/bridging as a compatibility alias for existing users. rdar://150298665 (cherry picked from commit 117199f)
Author
|
@swift-ci please test llvm |
Author
|
Failures seem unrelated: They appear to also be happening elsewhere: https://ci.swift.org/job/swiftlang-clang-stage1-RA/job/next/128/ |
Author
|
@swift-ci please test llvm |
egorzhdan
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place the
swift/bridgingheader in Clang's resource directory, so that it is automatically discoverable by both clang and swift. Also, add.hsuffix to the file so that headers can#include <swift/bridging.h>.Cherry-picked from #12861 and #13083
rdar://136716355
rdar://150298665