[lldb] Correct false case in SwiftOptionalSummaryProvider::DoesPrintChildren#13314
Open
kastiglione wants to merge 1 commit into
Open
Conversation
Author
|
@swift-ci test |
Author
|
@swift-ci test |
augusto2112
approved these changes
Jul 3, 2026
Author
|
@swift-ci test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return false from
DoesPrintChildrenfor.nonevalues.From the docstring for
ExtractSomeIfAny:/// Returns {} on error, nullptr on .none, and a ValueObject on .some.This changes the case where nullptr is returned, indicating
.none. In those cases, children should not be printed.I have seen an issue in the wild where "nil" is printed as the summary, yet children are incorrectly printed. I have not yet figured out a reproduction. An example output is: