[swift][shared-build] Add swift as a subproject#13319
Conversation
|
@swift-ci please test |
kastiglione
left a comment
kastiglione
left a comment
There was a problem hiding this comment.
Seems reasonable. I have two initial questions, as I read through the details.
| # The top-level target is named "swift-driver-prebuilt". Downstream | ||
| # targets (e.g. swift-frontend) can call: | ||
| # | ||
| # add_dependencies(<target> swift-driver-prebuilt) | ||
| # | ||
| # to ensure swift-driver is built before the target is linked/used. |
There was a problem hiding this comment.
Is adding a dependency on swift-driver-prebuilt (outside of this file) a scenario that you foresee being used elsewhere?
There was a problem hiding this comment.
if swift-driver-prebuilt is not expected to be used outside of this file, maybe the comment should be removed? If it is expected, can you comment which scenarios would call for adding a dependency on swift-driver-prebuilt.
There was a problem hiding this comment.
Yeah that was just a claudish comment that I didn't catch when cleaning up the PR. Removed as I don't see this being useful information future.
This patch sets up swift/ as an subproject that will be build in the same build folder/infrastructure as the rest of LLVM. The swift dependencies we need to build are added as external projects. This patch is a no-op when building with build-script.
Teemperor
force-pushed
the
LLDB-SwiftMonoSwiftProj
branch
from
8f48727 to
39aee99
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
2 participants
This patch sets up swift/ as an subproject that will be build in the same build folder/infrastructure as the rest of LLVM. The swift dependencies we need to build are added as external projects.
This patch is a no-op when building with build-script.