[LLDB] Add an API to check whether a variable is writable (#208042)#13343
Open
adrian-prantl wants to merge 2 commits into
Open
[LLDB] Add an API to check whether a variable is writable (#208042)#13343adrian-prantl wants to merge 2 commits into
adrian-prantl wants to merge 2 commits into
Conversation
Author
|
@swift-ci test |
b7a159a to
d8ba049
Compare
Author
|
@swift-ci test |
IDEs may offer functionality to set a variable to a specific value. There are many situations where this isn't actually possible, for example, if the variable's value is a constant or the result of a complex DWARF expression. Instead of offering to change a value only to have it fail with an error, this API lets the IDE query whether setting a value is generally feasible so it can hide the action where it isn't applicable. rdar://142358140 Assisted-by: claude (cherry picked from commit 349375a) Conflicts: lldb/source/Expression/DWARFExpressionList.cpp lldb/source/ValueObject/ValueObjectVariable.cpp lldb/unittests/Expression/DWARFExpressionTest.cpp
d8ba049 to
105b38c
Compare
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDEs may offer functionality to set a variable to a specific value. There are many situations where this isn't actually possible, for example, if the variable's value is a constant or the result of a complex DWARF expression. Instead of offering to change a value only to have it fail with an error, this API lets the IDE query whether setting a value is generally feasible so it can hide the action where it isn't applicable.
rdar://142358140
Assisted-by: claude
(cherry picked from commit 349375a)
Conflicts:
lldb/source/Expression/DWARFExpressionList.cpp
lldb/source/ValueObject/ValueObjectVariable.cpp
lldb/unittests/Expression/DWARFExpressionTest.cpp