Add missing semantic token modifier parameterLabel to documentation - #2738
Open
jansorg wants to merge 2 commits into
Open
Add missing semantic token modifier parameterLabel to documentation#2738jansorg wants to merge 2 commits into
parameterLabel to documentation#2738jansorg wants to merge 2 commits into
Conversation
Sync the semantic token modifiers with swift-tools-protocols
jansorg
changed the title
parameterLabel to documentation
rintaro
reviewed
Jul 28, 2026
Co-authored-by: Rintaro Ishizaki <fs.output@gmail.com>
Contributor
Author
|
Thanks for the suggestion. It's applied now. |
ahoppen
approved these changes
Jul 29, 2026
Member
|
@swift-ci Please test |
Member
|
@swift-ci Please test Windows |
Member
|
Windows failure is unrelated. Let’s try again @swift-ci Please test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the semantic token modifiers with https://github.com/swiftlang/swift-tools-protocols/blob/main/Sources/LanguageServerProtocol/SupportTypes/SemanticTokenModifiers.swift
A commit in swift-tools-protocols added
parameterLabel, which is not yet documented here.As far as I understand, both should be in sync.
I was unable to actually see
parameterLabelbeing returned in the list of available modifiers with Swift 6.3.3. But that may be caused by just testing with Objective-C files?